Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GVXR Material Import Error #47

Open
WYVERN2742 opened this issue Oct 6, 2022 · 0 comments
Open

GVXR Material Import Error #47

WYVERN2742 opened this issue Oct 6, 2022 · 0 comments
Assignees
@WYVERN2742
Labels
🐛 Bug Something isn't working Data/Config Data storage/transmission and Configuration

Comments

@WYVERN2742
Copy link
Contributor

Chained promises for new materials are not being executed in order, resulting in a race condition when setting a sample with non-id materials. Currently a refresh and re-import works fine, since the materials are still being created.
@WYVERN2742 WYVERN2742 added the 🐛 Bug Something isn't working label Oct 6, 2022
@WYVERN2742 WYVERN2742 self-assigned this Oct 6, 2022
@WYVERN2742 WYVERN2742 added this to WebCT Oct 6, 2022
WYVERN2742 added a commit that referenced this issue Oct 6, 2022
@WYVERN2742
feat: ✨ Config Loading & Exporting (#4) (#45)
094fb38 
📦 Different exporting types: WebCT and GVXR
- Toggle different sections for WebCT export
- Show Options for different exporting methods
- Easily create master config state object
- Framework for custom data loading and exporting
- Loaders are able to only partially populate the config
- Disable unusable elements for specific exporting types
- Download config as a file with download button

☢ GVXR Exporter:
- Full gvxr json representation, inc typed classes
- Create a gvxr-compatible config object from master config

☢ GVXR Importer:
- Added support for importing from GVXR
    - Parse gvxr config file
        - Load beam properties
            - Load tube type
                - Supports filters
            - Load specific energy level as a synchrotron source type
        - Load detector properties (inc lsf)
        - Load sample properties

🛠 Technical changes:
- Move setting and getting paramaters to functions
- Change SampleProperties to include nullable materialID and material
- Define SamplePropertiesID and SamplePropertiesMat to type specific material format
- Add Settings box in config panel
- Fix buttongroup by removing prefix icon 😢
- Define WebCTConfig type to manage saving/loading all properties
- Spans in checkboxes and switches now include smaller & grey font
- Sample update changes:
    - API now explicitly requires ID materials
    - Match material contents to existing ID materials
    - Create a new material if an existing material contents is not found
    - Automatically use generated new material IDs

🐛 Known Bugs:
- Race condition when importing from GVXR when creating new materials (#47)
    - Current workaround is to refresh and re-import the same config.
@WYVERN2742 WYVERN2742 moved this to 📋 Backlog in WebCT Oct 6, 2022
@WYVERN2742 WYVERN2742 moved this from 📋 Backlog to 🗂 Working List in WebCT Oct 19, 2022
@WYVERN2742 WYVERN2742 added the Data/Config Data storage/transmission and Configuration label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WYVERN2742 WYVERN2742

Labels
🐛 Bug Something isn't working Data/Config Data storage/transmission and Configuration
Projects
WebCT
Status: 🗂 Working List
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WYVERN2742