-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/TripPlaceAccommodation: (여행 숙소 선택 페이지) 기능 구현 1차 완료 #56
Merged
hyeonjuuu
merged 9 commits into
WeonTrip-WonT:develop
from
uniS2:feat/tripPlaceAccommodation
Mar 8, 2024
Merged
Feat/TripPlaceAccommodation: (여행 숙소 선택 페이지) 기능 구현 1차 완료 #56
hyeonjuuu
merged 9 commits into
WeonTrip-WonT:develop
from
uniS2:feat/tripPlaceAccommodation
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 선택한 정보 저장 기능 구현 예정
1. 현재 위치 업데이트 2. 숙박 카테고리 마커 표시 기능 분리 수정방향: 지도에 표시되는 마커 전역 관리 + 선택한 정보 전역 관리로 구현할 예정
- Tour API 내 외부 이미지 사용을 위해 작성 출처: https://nextjs.org/docs/app/building-your-application/optimizing/images#remote-images
- 마커 이미지: 무료 Icon 사이트 url.png로 변경 - 숙박 카테고리 지도 에러: 종속성 배열에 map 추가
- selectedAccommodation: 선택된 숙소 정보 - setToggleAccommodation: 선택한 숙소가 selectedAccommodation에 없을 경우, 있을 경우에 따른 추가/삭제 기능 - resetSelectedAccommodation: 선택한 숙소 정보 초기화
- LocalItem: Tour API Read 데이터(위치기반 숙소정보) - SelectItem: 선택된 숙소 정보 - 그 외 AccommodationStore 내 selectedAccommodation(선택된 숙소 정보 storage) 이용한 정보 렌더링 Related to WeonTrip-WonT#55
- TripEdit 페이지 접속시 AccommodationStore storage 초기화 참고: https://docs.pmnd.rs/zustand/integrations/persisting-store-data#clearstorage
hyeonjuuu
reviewed
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고 많으셨습니다!!
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
related #55
작업 내용
Types/DataProps.ts 파일 내
![AccommodationDataType 타입 선언](https://private-user-images.githubusercontent.com/134567469/311163590-b9e47c1b-5cd4-4183-b387-5b699f036d47.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MTk5ODYsIm5iZiI6MTczOTYxOTY4NiwicGF0aCI6Ii8xMzQ1Njc0NjkvMzExMTYzNTkwLWI5ZTQ3YzFiLTVjZDQtNDE4My1iMzg3LTViNjk5ZjAzNmQ0Ny5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQxMTQxMjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wYzUyZTc3NmZjNjM1MGQ1MGI2YjYxNDY5NDQzNTU5MWY2MDcyMDkwNDdiYzBmMjEyMGZlNTIwYjBmMWMwMjhiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.7t8kAU8G927-PddvnM0TcPXUVlZWC00-pWX81iAjnrw)
AccommodationDataType
Tour API '위치기반 숙소정보' Read 데이터 타입 선언Next configuration 파일 내 Tour API Image URL 패턴 작성
선택한 지역으로 지도 현재 위치 변경
Tour API Read 작업 및 데이터 내 좌표를 이용하여 숙소 마커 지도에 표시
지도에 표시되는 숙소 정보, 선택한 숙소 정보 및 관련 로직 Store 구현
![AccommodationStore storage](https://private-user-images.githubusercontent.com/134567469/311164700-2818ff02-2193-43bf-9f46-afa9252cf362.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MTk5ODYsIm5iZiI6MTczOTYxOTY4NiwicGF0aCI6Ii8xMzQ1Njc0NjkvMzExMTY0NzAwLTI4MThmZjAyLTIxOTMtNDNiZi05ZjQ2LWFmYTkyNTJjZjM2Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQxMTQxMjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lN2ZkMTg1ZTAyY2MyMGMyZGQ0OWYyZjk2NDI4YmVlOGJkMjI0Nzk0Y2JiNTc5NTY5ZmNkNmFhYWFkOWEzOWJhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.bDnzphPCT71tYC_bCRDZGfNIsWJnHjITJ9fAq8k_D18)
=>
AccommodationStore
storage의setToggleAccommodation
action을 통해selectedAccommodation
state에 선택한 숙소 정보 저장 중 입니다!달성도
레퍼런스
PR 체크리스트