Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect if storage has changed #147

Closed
WesleyBranton opened this issue Apr 29, 2022 · 1 comment · Fixed by #150, #153 or #161
Closed

Detect if storage has changed #147

WesleyBranton opened this issue Apr 29, 2022 · 1 comment · Fixed by #150, #153 or #161
Assignees
@WesleyBranton
Labels
enhancement New feature or request P3 This issue is considered medium priority

Comments

@WesleyBranton
Copy link
Owner

There are some scenarios where what's in the Storage API may have changed compared to what's on the user settings pages. For example, if the user is editing rules and adds a new rule via the popup window. Also, there's not technically anything preventing the user from opening the settings in more than one tab.

This could cause some data to be overwritten.

The options page should detect when there is a change in the Storage API and warn the user before saving the settings.
@WesleyBranton WesleyBranton added enhancement New feature or request P3 This issue is considered medium priority labels Apr 29, 2022
WesleyBranton added a commit that referenced this issue May 4, 2022
@WesleyBranton
Detect storage changes (#147)
da47617
@WesleyBranton WesleyBranton mentioned this issue May 4, 2022
Merged
@WesleyBranton WesleyBranton self-assigned this May 4, 2022
WesleyBranton added a commit that referenced this issue May 4, 2022
@WesleyBranton
Fixed dialog null exception (#147)
f062638
@WesleyBranton WesleyBranton mentioned this issue May 4, 2022
Merged
@WesleyBranton
Copy link
Owner Author

On Chromium, the user is getting this dialog when they save their scrollbar for the first time. The flag to ignore the next settings change appears to be set at the wrong time.

@WesleyBranton WesleyBranton reopened this Jul 27, 2022
WesleyBranton added a commit that referenced this issue Jul 27, 2022
@WesleyBranton
Fixed storage changes always triggering in Chrome (#147)
25a69eb
@WesleyBranton WesleyBranton mentioned this issue Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WesleyBranton WesleyBranton

Labels
enhancement New feature or request P3 This issue is considered medium priority
Projects
None yet
Milestone
No milestone
1 participant
@WesleyBranton