Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup domain validation failing for domains with numbers in the first two characters #154

Closed
WesleyBranton opened this issue May 4, 2022 · 0 comments · Fixed by #155
Closed
Assignees
Labels
bug Something isn't working P2 This issue is considered high priority

Comments

@WesleyBranton
Copy link
Owner

Domain validation is failing in a very specific situation in the toolbar popup. If the domain meets these requirements, it will be classified as invalid:

  • Has a subdomain
  • Has a non-letter character in the first 2 characters
    • Excludes the first subdomain

An example of a domain that fits into this category is www.w3schools.com.

const domainRegex = /^[a-zA-Z0-9][a-zA-Z0-9-]{1,61}[a-zA-Z0-9](?:\.[a-zA-Z]{2,})+$/;

@WesleyBranton WesleyBranton added bug Something isn't working P2 This issue is considered high priority labels May 4, 2022
@WesleyBranton WesleyBranton self-assigned this May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 This issue is considered high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant