Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patched issue with Firefox #94

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Patched issue with Firefox #94

merged 2 commits into from
Sep 10, 2021

Conversation

WesleyBranton
Copy link
Owner

Closes #91.

@WesleyBranton WesleyBranton merged commit 4202beb into main Sep 10, 2021
@WesleyBranton WesleyBranton deleted the patch branch September 10, 2021 01:50
@WesleyBranton
Copy link
Owner Author

Can you explain what is the "tabs" permission for?

Sure! There were some issues with the add-on not working after I made some changes to make the add-on work properly for content that's embedded within other content. Older versions need to have permission to access the browser tabs to be able to see what website is loaded in that tab. I've written a detailed explanation on the Why the addon needs permission to access browser tabs page.

For more information about the issue that prompted this change, take a look at issue #91.

The specific part of the code that is causing the issue is line 147 of background.js. That line of code is loading the URL (website address) of the page based on the user settings. The URL will either be loaded based on the page or based on the tab depending on the user settings.

Since it's not permission that every user needs to have depending on the version of their browser, I will see if I can make this an optional permission in a future update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firefox 78 not detecting tab URL
2 participants