Fix campaigns list rendering above recent news section issue on index page when navigating back via cancel button #6047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The campaigns list is supposed to be on this index page, but it is intended to render at the bottom of the page below the Recent News section (which it does usually, except when you navigate back this route via a cancel button). |
@ragesoss Just to be clear, 😅 it should render when we navigate via the cancel button, but it should appear below the Recent News section? |
Abishekcs
force-pushed
the
fix/campaign-table-appears-when-closing-modals
branch
from
9a9155a to
9a07fca
Compare
Abishekcs
changed the title
Abishekcs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This pull request fixes an issue where the campaigns list sometimes rendered incorrectly above the Recent News section when navigating back via the cancel button. The campaigns list now consistently appears below Recent News.
Screenshots
Before:
2024-12-08.18-13-42.mp4
After:
After.mp4
Cause of Bug :
The issue occurred because, in the HAML file, the HTML for the campaigns list was placed above the HTML for the Recent News section. This behavior was observed when the request path included /course_creator.