Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improved slug validation and error handling for courses #6089

Closed
wants to merge 2 commits into from
Closed

Fix: Improved slug validation and error handling for courses #6089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cffe73
add Validations
AliyanA1 Jan 4, 2025
d8f1fed
Update the def update to handle errors gracefully
AliyanA1 Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions app/controllers/courses_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,25 @@ def update
validate
handle_course_announcement(@course.instructors.first)
slug_from_params if should_set_slug?
@course.update update_params
update_courses_wikis
update_course_wiki_namespaces
update_flags
ensure_passcode_set
UpdateCourseWorker.schedule_edits(course: @course, editing_user: current_user)
render json: { course: @course }

if @course.update(update_params)
update_courses_wikis
update_course_wiki_namespaces
update_flags
ensure_passcode_set
UpdateCourseWorker.schedule_edits(course: @course, editing_user: current_user)
render json: { course: @course }
else
# If update fails, check for validation errors (e.g., duplicate slug)
render json: { errors: @course.errors.full_messages },
status: :unprocessable_entity
end
rescue Wiki::InvalidWikiError => e
message = I18n.t('courses.error.invalid_wiki', domain: e.domain)
render json: { errors: e, message: },
status: :not_found
end


def destroy
validate
Expand Down
3 changes: 3 additions & 0 deletions app/models/course.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ class Course < ApplicationRecord
######################
# Users for a course #
######################
# Validations
validates :slug, presence: true, uniqueness: { message: "Slug must be unique. Another course with this slug already exists." }

has_many :courses_users, class_name: 'CoursesUsers', dependent: :destroy
has_many :users, -> { distinct }, through: :courses_users
has_many :students, -> { where('courses_users.role = 0') },
Expand Down
Loading