Fix Rubocop Style/GuardClause Violations #6093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These look like nice style improvements to me. In principle I don't like adding exceptions just for the sake of avoiding the violation of another rule, and I think there might be some refactoring that could make that code a little more readable and satisfy both rules together. But that might be more trouble than it's worth, and I'm fine with leaving the inline exceptions in place at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in issue #5297, there are currently too many global exemptions to rubocop rules. One of them is Style/GuardClause.
In this PR, I removed that exemption and replaced violations with guard clauses where necessary.