Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new editor filter to the activity tab #6098

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shishiro26
Copy link
Contributor

@shishiro26 shishiro26 commented Jan 6, 2025

NOTE: Please review the pull request process before opening your first PR: [CONTRIBUTING.md](https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process)
#5527

What this PR does

This PR adds the registered_at field to user.json and uses it to filter out new editors by checking whether they registered after the course start date.

Screenshots

After:

2025-01-07.00-48-56.mp4

Open questions and concerns

when I tried to add a second button beside the first one, the first button did not receive a margin-left: 10px, while all subsequent buttons did. I have tried adjusting the styles but couldn’t pinpoint the exact cause of this issue.

@shishiro26
Copy link
Contributor Author

Could you please review this, @ragesoss?

@ragesoss
Copy link
Member

ragesoss commented Jan 7, 2025

It's on my todo list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants