fix: prevent mutation when updating course properties in Calendar's selectDay function #6139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes a mutation bug in the
selectDay
function of theCalendar
component. Thecourse
object was being directly mutated, which violates React's & Redux state management principles and can lead to unintended side effects.Cause of the bug
The
course
object fromthis.props
was being directly modified when updating theday_exceptions
andno_day_exceptions
properties. Sinceprops
are supposed to be immutable and plus this props is from redux slice passed all the way from Course component, this direct mutation could cause unexpected behaviors, such as incorrect renders or state inconsistencies.Fix of the bug
The fix involves avoiding direct mutation by creating a shallow copy of the
course
object and updating its properties immutably before passing it to theupdateCourse
function.Screenshots
Before:
Before.mp4
After:
After.mp4