Update codesniffer constraint to 45.0.0 and make pass

SEL-2103
WikiTeq · Nov 24, 2024 · 2a9513a · 2a9513a
1 parent c8d3978
commit 2a9513a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/composer.json b/composer.json
@@ -3,7 +3,7 @@
 		"ext-zip": "*"
 	},
 	"require-dev": {
-		"mediawiki/mediawiki-codesniffer": "44.0.0 || 43.0.0 || 38.0.0",
+		"mediawiki/mediawiki-codesniffer": "45.0.0 || 43.0.0 || 38.0.0",
 		"mediawiki/minus-x": "1.1.3 || 1.1.0",
 		"php-parallel-lint/php-console-highlighter": "1.0.0 || 0.5",
 		"php-parallel-lint/php-parallel-lint": "1.4.0 || 1.3.2 || 1.3.1"

diff --git a/includes/PagePort.php b/includes/PagePort.php
@@ -41,7 +41,7 @@ public function __construct(
 	 *
 	 * @return array
 	 */
-	public function import( string $root, string $user = null ): array {
+	public function import( string $root, ?string $user = null ): array {
 		if ( $user !== null ) {
 			$user = User::newFromName( $user );
 		} else {
@@ -66,7 +66,7 @@ public function import( string $root, string $user = null ): array {
 	 *
 	 * @return array
 	 */
-	public function delete( string $root, string $user = null ): array {
+	public function delete( string $root, ?string $user = null ): array {
 		if ( $user !== null ) {
 			$user = User::newFromName( $user );
 		} else {
@@ -326,14 +326,14 @@ static function ( $k ) {
 	public function exportJSON(
 		array $pages,
 		string $root,
-		string $packageName = null,
+		?string $packageName = null,
 		string $packageDesc = '',
-		string $repo = null,
-		string $version = null,
-		string $author = null,
-		string $publisher = null,
-		array $dependencies = null,
-		array $extensions = null,
+		?string $repo = null,
+		?string $version = null,
+		?string $author = null,
+		?string $publisher = null,
+		?array $dependencies = null,
+		?array $extensions = null,
 		bool $save = true
 	) {
 		global $wgLanguageCode;

diff --git a/tests/phpunit/PagePortTest.php b/tests/phpunit/PagePortTest.php
@@ -313,7 +313,7 @@ public function testGetNamespaceByValue( $input, $expected ) {
 	 * @covers PagePort::getAllPages
 	 * @dataProvider provideTestImport
 	 */
-	public function testImport( callable $callback = null ) {
+	public function testImport( ?callable $callback = null ) {
 		$tempDir = $this->tempdir( 'pageprot_' );
 		$pages = [
 			'Page1Test',