Add REL1_43 to CI matrices

Add REL1_43 to CI matrices, and relax composer version constraint to allow the
tests to pass.

Additionally, add a missing `__METHOD__` parameter that phan now complains
about.

SEL-1963

.github/workflows/mediawiki.yml

@@ -46,6 +46,8 @@ jobs:
             php: 7.4
           - mw: 'REL1_42'
             php: 8.1
+          - mw: 'REL1_43'
+            php: 8.1
     runs-on: ubuntu-latest
     steps:
       # check out the repository!
@@ -70,10 +72,12 @@ jobs:
       matrix:
         php: [ '7.4', '8.1' ]
         # Deliberately *not* testing against `master`
-        mediawiki: [ REL1_39, REL1_42 ]
+        mediawiki: [ REL1_39, REL1_42, REL1_43 ]
         exclude:
           - mediawiki: REL1_42
             php: '7.4'
+          - mediawiki: REL1_43
+            php: '7.4'
     steps:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2

composer.json

@@ -4,7 +4,7 @@
 	},
 	"require-dev": {
 		"mediawiki/mediawiki-codesniffer": "44.0.0 || 43.0.0 || 38.0.0",
-		"mediawiki/minus-x": "1.1.0",
+		"mediawiki/minus-x": "1.1.3 || 1.1.0",
 		"php-parallel-lint/php-console-highlighter": "1.0.0 || 0.5",
 		"php-parallel-lint/php-parallel-lint": "1.4.0 || 1.3.2 || 1.3.1"
 	},

includes/PagePort.php

@@ -169,7 +169,12 @@ private function getPagesFromDir( $dir ): array {
 	public function getAllPages(): array {
 		$pages = [];
 		$dbr = $this->loadBalancer->getConnection( DB_REPLICA );
-		$res = $dbr->select( 'page', [ 'page_title', 'page_namespace' ] );
+		$res = $dbr->select(
+			'page',
+			[ 'page_title', 'page_namespace' ],
+			'',
+			__METHOD__
+		);
 		if ( $res ) {
 			foreach ( $res as $row ) {
 				$cur_title = Title::makeTitleSafe( $row->page_namespace, $row->page_title );