This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
XW-3247 | Handle externaltest and showcase subdomains #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvas-damian
approved these changes
Apr 12, 2017
|
It's possible that we'll have CORS problem on production, but I'm not sure how I can reproduce it in testing environment. Although first pageview should be rendered correctly. Edit: I just hacked code a little bit and XHR to parent domain ends up with Cors error. Don't know if it's required for externaltest use-case. |
nandy-andy
approved these changes
Apr 12, 2017
|
Talked offline with @nandy-andy and @nefretete. Looks that first page-view is enough for now. |
kvas-damian
added a commit
that referenced
this pull request
Apr 12, 2017
XW-3247 | Handle externaltest and showcase subdomains
kvas-damian
added a commit
that referenced
this pull request
Apr 12, 2017
XW-3247 | Handle externaltest and showcase subdomains
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Description
Cut
externaltestandshowcaseprefixes from the host.Reviewers
@kvas-damian @nandy-andy