Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore dilib, which apparently is somehow still used in some spot-mapping jsp pages #923

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

naknomum
Copy link
Member

@naknomum naknomum commented Dec 5, 2024

this restores a library and pom.xml change, from PR909, which turned out to be still required by some wildbook functionality.

  • revert partial change to pom.xml
  • restore local-repo/ dir, with the single library needed
  • small note in a readme

@naknomum naknomum requested a review from TanyaStere42 December 5, 2024 00:43
Copy link
Member

@TanyaStere42 TanyaStere42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, restores everything and provides a solid explanation. waiting for deploy confirmation before merging

@naknomum naknomum changed the title restor dilib, which apparently is somehow still used restore dilib, which apparently is somehow still used in some spot-mapping jsp pages Dec 5, 2024
@naknomum
Copy link
Member Author

naknomum commented Dec 5, 2024

running locally:

  • tomcat is behaving as expected
  • able to login and see a few pages
  • encounterSpotVisualizer.jsp does not display jsp errors (as it did before with lib gone)

@naknomum naknomum merged commit 82b295b into main Dec 5, 2024
1 check passed
@naknomum naknomum deleted the restore-dilib branch December 5, 2024 23:16
Rodhlann pushed a commit to Rodhlann/Wildbook that referenced this pull request Dec 6, 2024
restor dilib, which apparently is somehow still used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants