add eslint-disable-line to prevent restricted globals error

[erinz2020]

This PR addresses an ESLint issue in service-worker.js by adding a directive (/* eslint-disable no-restricted-globals */) to prevent linting errors related to the use of self, which is required in the Service Worker context.

PR does not fix a numbered issue.

[TanyaStere42]

successful build, addresses issue. need to call this out in the docs as a necessary eslint-disable

[Rodhlann]

@erinz2020 I think I removed this in my last PR, so apologies if it caused any problems! How did the problem look, so I can be on the lookout in the future?

[TanyaStere42]

the error message was something like Unexpected use of 'self' no-restricted-globals React, and it was showing up only on the serviceworker.js. Very similar to this: https://stackoverflow.com/questions/44292520/unexpected-use-of-self-no-restricted-globals-react and all the research we did found that it's a big pain in the butt and they way people are working around it is to put in the disable

[erinz2020]

hi @Rodhlann yea I tried to add some rules to eslint.config.mjs but for some reason it didn't work, if you happen to know how to fix this please let me know, I've no idea about how this doesn't work

{
    files: ["**/service-worker.js"], 
    languageOptions: {
      globals: {
        ...globals.browser,
        serviceworker: true, 
        caches: "readonly",
        clients: "readonly",
        self: "readonly",
      },
    },
  },

[Rodhlann]

I think our current solution matches what the community was doing, though I'm still confused as to why it wasn't showing up for me.

I will say, it seems that the react-app-rewired package we install in frontend/maven-build.sh seems to follow its own eslint rules, and I wasn't able to figure out how to get that to use our eslint config, nor do I know if it's related to this specific problem.

[erinz2020]

I think our current solution matches what the community was doing, though I'm still confused as to why it wasn't showing up for me.

I will say, it seems that the react-app-rewired package we install in frontend/maven-build.sh seems to follow its own eslint rules, and I wasn't able to figure out how to get that to use our eslint config, nor do I know if it's related to this specific problem.

Agreed! I tried to make react-app-rewired follow our eslint rule by indicating our mjs in packge.json, but it didn't work either. so... adding back that line seems the best solution for us, at least for now.