Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unsharp mask #432

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Conversation

cpaniaguam
Copy link
Member

Extract logic for unsharp mask to specialized function leveraging built in clamp.

@cpaniaguam cpaniaguam linked an issue Sep 24, 2024 that may be closed by this pull request
@cpaniaguam cpaniaguam requested a review from a team September 24, 2024 20:33
@cpaniaguam cpaniaguam self-assigned this Sep 24, 2024
@cpaniaguam cpaniaguam added the enhancement New feature or request label Sep 24, 2024
@cpaniaguam cpaniaguam added this to the IFT Data Process milestone Sep 24, 2024
Copy link
Collaborator

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question here

src/normalization.jl Outdated Show resolved Hide resolved
@cpaniaguam cpaniaguam requested a review from a team September 30, 2024 20:42
Copy link
Collaborator

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more comments on the documentation, which seems to be out of date. Code looks good!

src/normalization.jl Outdated Show resolved Hide resolved
src/normalization.jl Outdated Show resolved Hide resolved
src/normalization.jl Outdated Show resolved Hide resolved
src/normalization.jl Outdated Show resolved Hide resolved
src/normalization.jl Outdated Show resolved Hide resolved
src/normalization.jl Show resolved Hide resolved
Co-authored-by: John Gerrard Holland <[email protected]>
danielmwatkins
danielmwatkins previously approved these changes Oct 4, 2024
@cpaniaguam cpaniaguam merged commit e84ce83 into main Oct 4, 2024
7 checks passed
@cpaniaguam cpaniaguam deleted the 431-create-dedicated-unsharp_mask-function branch October 4, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Create dedicated unsharp_mask function
3 participants