Feature/back/auth0 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Started integrating auth0 to the repository, separated controller into controller and router, moved database starting method to a separated file Referred issue: #30
Removed unused gin dependencies, changed docker-compose.yml for it to use env ports Referred issue: #30
Added gin to the application, still need to figure why the authenticator isn't working Referred issue: #30
Now routes are protected, added authentication functionality, made some changes in config. BREAKING CHANGE: Can now protect routes with Auth0 Referred issue: #30
Referred issue: #30
GuidoM197
approved these changes
Jan 28, 2025
Comment on lines
+57
to
61
| routerError := ginRouter.Run(":" + serverPort) | ||
| if routerError != nil { | ||
| fmt.Println("Failed to start server") | ||
| return | ||
| } |
There was a problem hiding this comment.
Estos son detalles de escritura de go, podrías reemplazar este pedazo de código por:
if routerError := ginRouter.Run(":" + serverPort); routerError != nil {
fmt.Println("Failed to start server")
return
}Sin embargo, esto no siempre funciona. Esto es debido a que en el caso de que esta funcion retorne 2 valores, nos presentara un error si usamos alguno de estos en la posterioridad. Esto pasa ya que en un if existe la posibilidad de que nunca suceda lo que sigue despues de este.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.