Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinRM V2 #191

Merged
merged 238 commits into from
Aug 31, 2016
Merged

WinRM V2 #191

merged 238 commits into from
Aug 31, 2016

Conversation

sneal
Copy link
Member

@sneal sneal commented Feb 25, 2016

closes #106, #105, #169, #197, #203, #208, #194

@mwrock
Copy link
Member

mwrock commented Mar 1, 2016

Got Powershell running here with equivelent functionality as the spike. Just need to properly parse the powershell output from the binary blob.

Connection.shell now takes a block and will close the shell when the block completes if given. While the finalizer should take care of this, this allows for earlier freeing of the connection if necessary.

Also added a run_wql right off of connection since wql is not run in a shell.

@mwrock
Copy link
Member

mwrock commented Mar 12, 2016

Found some time to get back to this last night. The MessageFactory now has a parse_bytes method that can create a psrp message from raw bytes. I added accessors for each part described in the spec. Currently we munge fragments into the outer message shell but we can decompose that when we need to.

There is an additional decoder now specifically for powershell however we may soon need to break up the output processor as well. This will all definitely need some refactoring after the rest of the output handling is added.

Currently it can handle basic powershell output. It cant yet handle error responses nor does it deal well with commands containing quotes and line endings. So thats gonna be next.

@mwrock
Copy link
Member

mwrock commented Mar 13, 2016

Just rebased on top of current master. Both unit and integration tests are green "on my machine" but looks like something is not appveyor friendly.

Beyond fixing appveyor there is some rather heinous stuff going on in output processing with the message_types and code duplication. Will clean that up.

@sneal
Copy link
Member Author

sneal commented Mar 13, 2016

@mwrock Exciting! I plan to get back to this sometime later this week.

@chris-rock
Copy link
Contributor

Guys, you do awesome work!

@sneal
Copy link
Member Author

sneal commented Jul 30, 2016

Finally looking at this again for the first time in a few months...

@sneal
Copy link
Member Author

sneal commented Aug 4, 2016

Since we're breaking backwards compatibility, I'd like to have the Output class not be a Hash.

@mwrock
Copy link
Member

mwrock commented Aug 4, 2016

Sounds good @sneal. I'm thinking of essentially just exposing an exitcode method and, at least for now, keeping a internal hash to track the data so much of the inner Output code will remain the same you just won't be able to access it as a hash. That sound good?

@mwrock
Copy link
Member

mwrock commented Aug 5, 2016

@sneal Here is what I have the output looking like: https://gist.github.com/mwrock/470d06301dff66c2b20b41d67c39a62a

@mwrock
Copy link
Member

mwrock commented Aug 5, 2016

I'll be adding yard docs, etc, etc

@mwrock
Copy link
Member

mwrock commented Aug 5, 2016

Updated Output and added commits to all downstream PRs

@mwrock mwrock merged commit 6f4a0d2 into master Aug 31, 2016
@sneal
Copy link
Member Author

sneal commented Aug 31, 2016

@mwrock It just got real!

@mwrock
Copy link
Member

mwrock commented Aug 31, 2016

oh yeah!

nicolasvan added a commit to red-gate/specinfra that referenced this pull request Oct 28, 2016
temyers pushed a commit to temyers/specinfra that referenced this pull request Feb 24, 2017
@pcai pcai deleted the winrm-v2 branch June 7, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle serialized CLIXML OutputFormat
4 participants