Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unnecessary printf() statements #8

Closed
lorenzo-gomez-windhover opened this issue Dec 2, 2020 · 1 comment
Closed

Remove Unnecessary printf() statements #8

lorenzo-gomez-windhover opened this issue Dec 2, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@lorenzo-gomez-windhover
Copy link
Collaborator

In juicer.cpp there are printf statements that are displayed regardless of the log level passed to juicer. We should strive to have ALL messages be processed by logger; this way the user has more(ideally complete) control over what messages get printed.

@lorenzo-gomez-windhover lorenzo-gomez-windhover added the enhancement New feature or request label Dec 2, 2020
@lorenzo-gomez-windhover
Copy link
Collaborator Author

Has been resolved in 0833c9f.

mbenson1 pushed a commit that referenced this issue Feb 9, 2021
* -Removed printfs. Fixes #8.

* -Switchedd DWARF parsing output to DEBUG

* -Absolute elf paths are enforced now
-TODO:Update unit tests

* -Unit tests have been updated; absolute elf paths are tested now
mbenson1 added a commit that referenced this issue Mar 11, 2021
* -Removed printfs. Fixes #8.

* -Switchedd DWARF parsing output to DEBUG

* -Absolute elf paths are enforced now
-TODO:Update unit tests

* -Unit tests have been updated; absolute elf paths are tested now

* Fixes to the Makefile. It works with Makefile v3.80 now.

* Adding additional forms.

* Completed adding the necessary patterns to support VxWorks 6.9

* -Handle endianess properly when writing to database
-Use libelf macros for endianess

* Resolved merge request comment to add additional comments.

* -Goodbye xenial...

Co-authored-by: lorenzo-gomez-windhover <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant