vcrun6sp6 borked, fails

[Baerbeisser]

This vcrun seem(ed) to be needed to make kenshi run in wine.

winetricks.log

[austin987]

warning: You are running winetricks-20230212, latest upstream is winetricks-20240105!

Please upgrade to the latest release before reporting issues.

[Baerbeisser]

Done, installation still fails. Same for vcrun 2010 (error 96) btw.
I moved XDG_CACHE_HOME to .local/tmp, incase you're wondering.
winetricks.log

+ [ -z  ]
+ printf %s\n Executing cabextract -q /home/dani/.local/tmp/winetricks/vcrun6sp6/VS6SP6.EXE -d /home/dani/.wine/dosdevices/c:/windows/temp -F vcredist.exe
Executing cabextract -q /home/dani/.local/tmp/winetricks/vcrun6sp6/VS6SP6.EXE -d /home/dani/.wine/dosdevices/c:/windows/temp -F vcredist.exe
+ cabextract -q /home/dani/.local/tmp/winetricks/vcrun6sp6/VS6SP6.EXE -d /home/dani/.wine/dosdevices/c:/windows/temp -F vcredist.exe
-d: No such file or directory
/home/dani/.wine/dosdevices/c:/windows/temp: Is a directory
-F: No such file or directory

I tried to cabextract -q VS6SP6.EXE -d $PWD/tmp -F vcredist.exe in ...tmp/winetricks/vcrun6sp6 locally
but

-d: No such file or directory
/home/dani/.local/tmp/winetricks/vcrun6sp6/tmp: Is a directory
-F: No such file or directory

everything was dumped here though, vcredist.exe exists, is cabextract broken?

edit: proton-ge-patched wine didn't make things simpler either, sorry. Switched to wine-staging.

[Chiitoo]

I can not re-produce this behaviour here.

What is your cabextract version and source for it, and what shell are you using?

While cabextract --help does state

Usage: cabextract [options] [-d dir] <cabinet file(s)>

it does still work for me in the order Winetricks uses it (version 1.11 from https://www.cabextract.org.uk/).

[Baerbeisser]

I have 1.11 too (Arch), so that shouldn't be it.
Tested it, cabextract doesn't like the .exe before the options, it wants them after.
cabextract -q -d .../c:/windows/temp -F vcredist.exe .../winetricks/vcrun6sp6/VS6SP6.EXE
instead of
cabextract -q .../winetricks/vcrun6sp6/VS6SP6.EXE -d .../c:/windows/temp -F vcredist.exe
in load_vcrun6sp6.

btw, vcrun2010 works now.

edit:

Repository      : world
Name            : cabextract
Version         : 1.11-1
Description     : A program to extract Microsoft cabinet (.CAB) files
URL             : https://www.cabextract.org.uk/
Build Date      : Mon Feb 27 22:55:13 2023

using Bash. And Dash for non-interactive.

[Chiitoo]

It is quite mysterious since it works for me both, manually used like it is in Winetricks, and via Winetricks itself. >.<

[Baerbeisser]

Well, since the manpage says
cabextract [-ddir] [-eencoding] [-f] [-Fpattern] [-h] [-i] [-k] [-l] [-L] [-n] [-p] [-q] [-s] [-t] [-v] cabinet files ...
translation: cabextract [options] exe
i say, better go with that.
Might affect other winetricks-scripts as well.

[austin987]

Nice find, thanks @Baerbeisser. Just to verify, austin987@ec809c4 fixes this for you, right?

There are definitely other offenders, if that's the issue. I also have cabextract-1.11 (on debian) and either way works. Interestingly, the Arch package doesn't seem to be applying a custom patch: https://gitlab.archlinux.org/archlinux/packaging/packages/cabextract/-/blob/main/PKGBUILD?ref_type=heads

I'm going to try the Arch VM from https://www.osboxes.org/arch-linux/, hopefully that can reproduce it..

[Baerbeisser]

Just to verify, austin987/winetricks@ec809c4 fixes this for you, right?

Yes, looks like.
And thanks for digging!

Btw, how to update winetricks installer scripts? I used the wget line from the frontpage to get the uptodate binary but that's only the binary.

[austin987]

Btw, how to update winetricks installer scripts? I used the wget line from the frontpage to get the uptodate binary but that's only the binary.

I'm not sure what installer scripts you're referring to. If you clone the repo you could use the Makefile, but there's not an installer script, per se. Most of the other files in the repo are for development (aside from the manpage/bash completion, which aren't updated very frequently).

[Baerbeisser]

The script/definitions winetricks uses to know where to get VS6SP6.EXE, what to do with it, etc.

Wait, this is all in the 20'000 loc shell script?

[austin987]

Yup.

[Baerbeisser]

Wow. :)

Well, i downloaded winetricks again
curl https://raw.githubusercontent.com/Winetricks/winetricks/master/src/winetricks -o $XDG_BIN_HOME/winetricks
and tried winetricks vcrun6sp6 in a fresh prefix but i still get the cabextract error.

edit: nevermind. After uninstalling winetricks from the repo it works.

Thanks for your help!