Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #239 by explicitly declaring Jsonnet API functions used #240

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

brettviren
Copy link
Member

At least, perhaps. I could not reproduce the problem. This explicitly declares the Jsonnet API functions instead of including the header that is causing FNAL problems

Perhaps.  I could not reproduce the problem.  This explicitly declares the Jsonnet API functions instead of including the header that is causing FNAL problems
@brettviren brettviren requested a review from HaiwangYu August 23, 2023 23:33
@HaiwangYu
Copy link
Member

HaiwangYu commented Aug 24, 2023

Hi Brett, I got an error when trying to compile with g++ (GCC) 9.3.0

g++: error: unrecognized command line option '-Wc99-extensions'; did you mean '-fms-extensions'?

Is that flag needed?
Other than that, I can build and run tests with out issue.

@brettviren
Copy link
Member Author

Arg, darn! Sorry, that was meant to be a temporary addition to try to get clang to reproduce the problem that Lynn reported. I'll refresh the three branches.

@brettviren
Copy link
Member Author

@HaiwangYu

It was perhaps fortuitous to take another pass as we were missing many compiler warnings in WCT 0.24.x (still many in boost we can't fix).

This PR branch and the 0.24.x and 0.25.x branches have -Wc99-extensions removed. In addition I updated the release branches a bit more:

  • 0.24.x added fixes for many compiler warnings found by clang and one failed test due to clang 14 changing how it demangles C++ symbols.
  • 0.25.x remove one compiler warning GCC found.

I believe I've tested all 3 branches X 2 compilers. Hopefully I didn't miss a matrix element.

@HaiwangYu HaiwangYu merged commit a24a65c into master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants