Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some in-dev code and speed up of conversion code #267

Merged
merged 12 commits into from
Jan 2, 2024

Conversation

HaiwangYu
Copy link
Member

Significant speed up of MultiAlgBlobClustering

[11:58:42.788] D [  img   ] <PointTreeBuilding:pct-buiding-uboone> samples -> keys 31 size_major 21
[11:58:44.339] D [  img   ] <PointTreeBuilding:pct-buiding-uboone> sampled 15077 blobs from set 6501 making 512895 tensors at call 0
[11:58:44.530] D [  img   ] <MultiAlgBlobClustering:multi-alg-blob-clustering-uboone> After merging, Got 512895 tensors
[13:05:14.059] D [  img   ] <MultiAlgBlobClustering:multi-alg-blob-clustering-uboone> Got pctree with 276 children
[13:05:14.148] D [  img   ] <MultiAlgBlobClustering:multi-alg-blob-clustering-uboone> Made 15354 tensors
[13:05:14.519] D [  sio   ] <TensorFileSink:tensorsink-uboone> dumping tensor set ident=6501 at call 0
...
[13:05:14.544] I [ timer  ] Timer: WireCell::Img::MultiAlgBlobClustering : 3990.04 sec
[13:05:14.545] I [ timer  ] Timer: WireCell::Img::PointTreeBuilding : 13.68 sec
[15:23:14.671] D [  img   ] <PointTreeBuilding:pct-buiding-uboone> load cluster 6501 at call=0: graph: 57433 nodes of 5 types: b:15077 c:6016 m:28128 s:2196 w:6016 bcats:[ okay=15077 null=0 nostrips=0 nowidth=0 nocorners=0 novolume=0] 349197 edges of 6 types: bb:35245 bm:45065 bw:147347 cm:100447 cw:6016 sb:15077
 channels:  0x3c2eaf0 8131 0x3c2e960 8130 0x3c2e7d0 8129 0x3e82100 4330 0x3ce0570 4329 0x3b80900 6807 0x3dcf0f0 1517 0x3dce850 1521 0x3ceea10 2073 channel hash: 9729118241047941495 total blob charge: 174507289.8197931
nblobs: 15077
[15:23:14.709] D [  img   ] <PointTreeBuilding:pct-buiding-uboone> got 276 clusters
[15:23:24.099] D [  img   ] <PointTreeBuilding:pct-buiding-uboone> Made 512895 tensors
[15:23:24.111] D [  img   ] <PointTreeBuilding:pct-buiding-uboone> sampled 15077 blobs from set 6501 making 512895 tensors at call 0
[15:23:24.290] D [  img   ] <MultiAlgBlobClustering:multi-alg-blob-clustering-uboone> After merging, Got 512895 tensors
[15:23:26.885] D [  img   ] <MultiAlgBlobClustering:multi-alg-blob-clustering-uboone> Got pctree with 276 children
[15:23:28.624] D [  img   ] <MultiAlgBlobClustering:multi-alg-blob-clustering-uboone> Made 512895 tensors
[15:23:29.432] D [  sio   ] <TensorFileSink:tensorsink-uboone> dumping tensor set ident=6501 at call 0
[15:23:29.793] I [ timer  ] Timer: WireCell::Img::PointTreeBuilding : 9.63 sec
[15:23:29.793] I [ timer  ] Timer: WireCell::Img::MultiAlgBlobClustering : 5.14 sec

@HaiwangYu HaiwangYu marked this pull request as ready for review December 18, 2023 20:38
@HaiwangYu HaiwangYu requested a review from brettviren December 18, 2023 20:38
Copy link
Member

@brettviren brettviren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine. Does this supersede #262?

FYI, I made some notes with one idea to "really" clean up this TDM I/O stuff in #268. It probably requires more effort than it is worth unless the use of TDM takes off in some larger context.

@HaiwangYu
Copy link
Member Author

Thanks! @brettviren. Yes, this supersede #262. Will close that one. Should I merge this one for now?

@brettviren
Copy link
Member

Should I merge this one for now?

Yeah, go for it!

@HaiwangYu HaiwangYu merged commit 4b5300e into WireCell:apply-pointcloud Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants