tmp solution for ICARUS #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettviren
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
My understanding is this will save each set of tagged traces based on if the corresponding tag name is either set to some string or is empty. It is reasonable and I'd say this is how it really should have been all along.
It also makes m_use_roi_debug_mode redundant with the various extra trace tag name variables. I suggest to remove the configuration parameter for debug mode and instead make it internal. That is, set this variable if any of the special tag trace name configuration parameters are provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to be a tmp solution for the high mem situation due to the special ICARUS usage. Still need to sort things out further:
debug note:
2024-02-09_high-mem.pdf