Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a perchannel resp correction #279

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

wenqiang-gu
Copy link
Member

@wenqiang-gu wenqiang-gu commented Mar 13, 2024

It's similar to PerChannelResponse, except that it uses a parameterized cold electronics function based on Xin's formula. An example response function is below:
image

Parameters for such response can be read from a json input file with a format below:

{
    "tick": 500.0,
    "t0": -2750.0,
    "channel_info": [
      {
        "channels": [0,1,2, ...],
        "gain": 1,
        "shaping": 1,
        "k3": 1,
        "k4": 1,
        "k5": 1,
        "k6": 1
      }
      {
        "channels": [4,5,6, ...],
        "gain": 1,
        "shaping": 1,
        "k3": 1,
        "k4": 1,
        "k5": 1,
        "k6": 1
      }

    ]
}

To use this ParamsPerChannelResponse in the signal processing, one need to enable it in the local params.jsonnet:

chresp: "protodunevd-params-channel-responses-v0.json.bz2", // default: null

@wenqiang-gu wenqiang-gu requested a review from brettviren March 13, 2024 18:21
@wenqiang-gu
Copy link
Member Author

Hi @brettviren , we may discuss this update at this week's WireCell meeting. As suggested by Xin's meeting policy, I think it would be good if we could have some sort of agreement before the meeting.

Copy link
Member

@brettviren brettviren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good.

@wenqiang-gu wenqiang-gu merged commit 4764875 into master Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants