Initial merged works as future common base #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new interface called IClusterFaninTensorSet to the WireCellIface namespace. The interface is a fan-in node that takes IClusters as input and outputs an ITensorSet. The commit also includes the necessary header and source file changes to implement the interface.
Eg:
../img/src/PointTreeBuilding.cxx:190:35: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
auto cnode = root->insert(std::move(std::make_unique<Points::node_t>()));
We should not use std::move() here because the return of make_unique() is already an lvalue. Likewise in code like:
cnode->insert(Points(std::move(pcs)));
The Points() constructor returns a temporary which is also an lvalue.
C++ will automaticaly move lvalues to their destination (copy elision).
And for reasons I do not yet understand, std::move() defeats that.
workflow almost work
Any TensorDM function that took an ITensor::vector now also takes a TensorIndex
… as output by just BlobClustering)
Fix some ICluster I/O
…lkit into apply-pointcloud
…-cell-toolkit into brettviren-apply-pointcloud
HaiwangYu
commented
Mar 19, 2024
| @@ -214,7 +214,7 @@ namespace { | |||
| const auto& z = pc_scalar.get("z")->elements<float_t>(); | |||
| std::vector<Point2D> points; | |||
| for (size_t i = 0; i < y.size(); ++i) { | |||
| points.push_back({y[i], z[i]}); | |||
| points.push_back({(float)y[i], (float)z[i]}); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref (before merging)
BEE: https://www.phy.bnl.gov/twister/bee/set/7dc1d888-ee96-4f0b-9585-96586fada5b6/event/6501/
log: https://www.phy.bnl.gov/~yuhw/wcp-porting-img/tensor-index-merging/ref-O2.log
Initial test (right after merging conflicts) looks good:
BEE: https://www.phy.bnl.gov/twister/bee/set/529c9763-4554-4cfb-8994-9f33396bb15f/event/6501/
log: https://www.phy.bnl.gov/~yuhw/wcp-porting-img/tensor-index-merging/merging-conflicts-O2.log