Spdir metric #287
Merged
Spdir metric #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to implemente resampling in NF instead of just python
Previously, it was also placing prior depos in the output set. That bug would not be tickled when the input file contains only active depos. Until recently, apparently, nobody tried to read back a file of drifted depos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the "spdir" work.
It is most new files and changes to
cfg/layers/with some random fixes and improvements of existing.cxxthat were found along the way.Main C++ changes that I feel deserve some scrutiny are updates to the "tag
logic" in
L1SPFilterandOmnibus*NoiseFilterto deal with the case of emptytags.
The rest are likely fine but another set of eyeballs is always welcome:
Some logging related updates to various
.cxxto removecoutand useAux::Logger.Some blocking of a flood of
cerrmessages fromMicroboone.cxxBug fixes in
DepoFileSource.Clarify logic in
FrameFileSource.