Fix spdlog fmtlib

[brettviren]

This fixes WireCell/wire-cell-spack#12

[brettviren]

@HaiwangYu it's hard for me to test on old spdlog with built-in fmtlib but hopefully it now compiles for you.

[HaiwangYu]

Now the errors changed for me (spdlog 1.8.2):
https://www.phy.bnl.gov/~yuhw/larsoft925/src/wct-latest/log

[brettviren]

@HaiwangYu is your spdlog compiled with the bundled fmt or is there an explicit external fmt (fmtlib)? If the latter, what version of fmtlib?

[HaiwangYu]

@brettviren I think it is bundled. I found this folder:

$ll $SPDLOG_FQ_DIR/include/spdlog/fmt/bundled 
total 450K
-rw-r--r-- 1 125 128 1.4K Dec 11  2020 LICENSE.rst
-rw-r--r-- 1 125 128  35K Dec 11  2020 chrono.h
-rw-r--r-- 1 125 128  24K Dec 11  2020 color.h
-rw-r--r-- 1 125 128  24K Dec 11  2020 compile.h
-rw-r--r-- 1 125 128  70K Dec 11  2020 core.h
-rw-r--r-- 1 125 128 108K Dec 11  2020 format-inl.h
-rw-r--r-- 1 125 128 130K Dec 11  2020 format.h
-rw-r--r-- 1 125 128 2.3K Dec 11  2020 locale.h
-rw-r--r-- 1 125 128  14K Dec 11  2020 os.h
-rw-r--r-- 1 125 128 5.8K Dec 11  2020 ostream.h
-rw-r--r-- 1 125 128   75 Dec 11  2020 posix.h
-rw-r--r-- 1 125 128  23K Dec 11  2020 printf.h
-rw-r--r-- 1 125 128  13K Dec 11  2020 ranges.h

[brettviren]

@HaiwangYu sorry for the iteration on this. I have a new try which should work. Tested on various versions of spdlog/fmtlib as described in the wire-cell-spack Issue. Though, those tests were done outside of WCT so there is still room for something to go wrong.

[HaiwangYu]

Hi @brettviren, it almost worked for me with only this:

../util/test/test_rayclustering.cxx:3:10: fatal error: fmt/core.h: No such file or directory
    3 | #include <fmt/core.h>
      |          ^~~~~~~~~~~~
compilation terminated.

[757/757][100%][/][==================================================================================>][4.794s]
Waf: Leaving directory `/home/yuhw/wc/larsoft925/src/wct-latest/build'
Build failed
 -> task in 'test_rayclustering' failed with exit status 1 (run with -v to display more information)

[brettviren]

@HaiwangYu this was a stray direct include that is apparently not even needed. I just pushed a commit to remove it. Please try one more time.

[HaiwangYu]

Thanks! It now compiles and Sim/SigProc seems to be correct.
wirecell pr296.pdf