-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove h5cpp in favor of just HDF5 C API. #314
Conversation
Builds fails at runtime
Clearly a benign bug as it has been this way for a while.
This looks to be working now. I check that ADC and SP input from npz come out has HDF5 which can be plotted and look "normal". It would be very good to check with an old job to see if anything beyond these broke. O.w., I am ready for merge on my side. I have mostly tried to keep configuration interface consistent but there are some changes:
Use of ignored params results in logged warnings. Here is a summary of performance as a function of ADC with digitze=true and SP with digitize=false as a function of gzip level and square chunk size.
To remake, run something like:
In general:
Default is no compression but perhaps a gzip level of 1 or 2 and the current chunk size of 256 would make a good compromise. |
Hi @brettviren, Thanks a lot for fixing this!
Notes: |
This is to address #192
To start out with we limit the scope:
HDF5FrameTap
To start with we achieve the first two but HDF5 crashes. The C API is probably not being properly used. But, enough of a scaffold is in this PR to start to improve things.