Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace grouped filter with multigroup channel filters #328

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

wenqiang-gu
Copy link
Member

@wenqiang-gu wenqiang-gu commented Aug 15, 2024

Implement the multigroup channel filters as discussed in #327

To maintain backwards compatibility, the "grouped_filter" interface is kept. Here is an example to use the new interface in the configuration:

type: 'OmnibusNoiseFilter',
data: {

  grouped_filter: [ ] // keep empty for backwards compatibility
                     // need to assign empty array explicitly otherwise "mbCoherentNoiseSub" filter
                      // would be used: cfg["grouped_filters"][0] = "mbCoherentNoiseSub"; 

  multigroup_coherent: [
    // The order of execution is important
    {
      channelgroups: chndb.data.femb_groups;
      filters: [wc.tn(filter1), … ]
     },

    {
      channelgroups: chndb.data.groups; // coherent channel groups
      filters: [wc.tn(filter2), … ]
     },

  ],
}, 

@wenqiang-gu
Copy link
Member Author

Here, I add a sanity check for the PDHD data after running coherent noise filters with different configuration:
image

@HaiwangYu
Copy link
Member

Compiles and the SigProc results look identical with 0.27.1
Screenshot 2024-08-16 at 3 19 57 PM

@HaiwangYu HaiwangYu merged commit 4e1e5b3 into master Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants