Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/calcuttj padding clean2 #341

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

calcuttj
Copy link

Includes padding additions for the issues presented by Gray. This is based off an earlier commit than the head of master because when I updated it, it wouldn't build correctly when configured for ups because of new additions to wscript

@brettviren
Copy link
Member

Gray gave thumbs up on ICARUS tests via email @HaiwangYu please take a look and merge if/when you are okay.

@HaiwangYu
Copy link
Member

@brettviren, great! I will merge it soon.

@HaiwangYu
Copy link
Member

@calcuttj, thanks for making this PR. I did some tests and this PR results a segfault for a sim-sigproc test for PDSP single APA. See page 5 and 6 of this note:
pr341.pdf

Could you look into this when having an opportunity? Thanks!

@calcuttj
Copy link
Author

Fixed

    /nfs/data/1/calcuttj/segfault_test/toolkit/gen/test/test-lmn-fr-pdsp.bats [37.854s] 
    **/nfs/data/1/calcuttj/segfault_test/toolkit/test/test/test-pdsp-simsn-nfsp.bats [38.884s]** 
    /nfs/data/1/calcuttj/segfault_test/toolkit/test/test/test-spdir-metric-pdsp.bats [2m16.872s] 
    /nfs/data/1/calcuttj/segfault_test/toolkit/img/test/test-tenio.bats [4m1.494s] 
    /nfs/data/1/calcuttj/segfault_test/toolkit/test/test/history-comp1d.bats [26.501s] 
  tests that fail 7/221 
    /nfs/data/1/calcuttj/segfault_test/toolkit/build/util/test_util_stream [0.096s] 
    /nfs/data/1/calcuttj/segfault_test/toolkit/test/test/test-issue220.bats [0.775s] 
    /nfs/data/1/calcuttj/segfault_test/toolkit/test/test/test-morse-pdsp.bats [11.941s] 
    /nfs/data/1/calcuttj/segfault_test/toolkit/test/test/test-ssss-pdsp.bats [17.791s] 
    /nfs/data/1/calcuttj/segfault_test/toolkit/img/test/test-wct-uboone-img-full.bats [1m40.412s] 
    /nfs/data/1/calcuttj/segfault_test/toolkit/img/test/test-wct-uboone-img.bats [1m49.843s] 
    /nfs/data/1/calcuttj/segfault_test/toolkit/test/test/test-spdir-metric-uboone.bats [5m0.233s] 
'build' finished successfully (5m32.616s)

@HaiwangYu
Copy link
Member

@calcuttj thanks for fixing this. I will test this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants