Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler error and some DNNROI related updates #344

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Conversation

HaiwangYu
Copy link
Member

No description provided.

@HaiwangYu HaiwangYu marked this pull request as ready for review October 5, 2024 20:08
@HaiwangYu
Copy link
Member Author

tested OK:
https://indico.bnl.gov/event/25041/

@brettviren
Copy link
Member

Hi @HaiwangYu

I think this PR is okay but the lack of torch::Tensor::index() in v1.6 surprises me. Is there really no way to index tensors in torch 1.6? I know one can construct a strongly typed and dimensioned "accessor", at least in LibTorch 2.x, but this lacks the "pythonic" indexing syntax.

https://pytorch.org/cppdocs/notes/tensor_basics.html#efficient-access-to-tensor-elements

@HaiwangYu
Copy link
Member Author

There could be alternatives like index_select? Haven't tried that yet.

Copy link
Member

@wenqiang-gu wenqiang-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code in OmnibusSigProc, and everything looks good to me.

@HaiwangYu HaiwangYu merged commit fa806da into master Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants