Modal build #361
Open
Modal build #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If "master" or a release branch then the build is "release mode" else it is "development mode". In release mode, disable any packages not ready for release (eg patrec) and make the compiler more strict. Fixes #305. Currently, development mode (building in a feature branch) has no changes from nominal. This commit improves setting VERSION and adds support for providing the version in a "version.txt" file when the source is not under git control. Fixes #112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the build modal depending on git branch.
If "master" or a release branch then the build is "release mode" else it is "development mode".
In release mode, disable any packages not ready for release (eg patrec) and make the compiler more strict. Fixes #305.
Currently, development mode (building in a feature branch) has no changes from nominal.
This commit improves setting VERSION and adds support for providing the version in a "version.txt" file when the source is not under git control. Fixes #112.
But, note, we must do something new in order to assure
version.txtexists in pure-source releases. We do not typically make tarball source releases and I do not know how to inject this file in the tarballs that GitHub makes automatically so this feature will likely remain vestigial.