Refresh of tbb engine #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds config.h and test for fftw3 threads
wenqiang-gu
pushed a commit
that referenced
this pull request
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR summarized recent work on refreshing the tbb engine by @brettviren and @HaiwangYu
PgrapherversionFanoutCatnode wrapper so that we could construct graphs with fanout nodes@brettviren and I noticed the
fftwplanner is NOT thread safe by default:http://www.fftw.org/fftw3_doc/Thread-safety.html
We need the
libfftw*_threads.solibraries to make it run in thread-safe mode.These libraries would be provided in future larsoft update.
Right now many larsoft services are also NOT thread-safe and marked as 'Legacy'.
To run
larin MT mode, the configuration should not contain those legacy services.Test on this 'sim-nf-sp' chain:
CPU and memory profiling:
Test on real data with 'larwirecell':
Related presentations:
https://indico.bnl.gov/event/6817/contributions/31594/
https://indico.bnl.gov/event/5911/contributions/31422/