-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a Command-Line Interface #3
Conversation
…cking issue of google
Hi @MahmoudElsayad! Thank you so much for suggesting a pull request! I am quite admired by the effort that you put here! I especially liked the 500ms delay to solve the robot blocking :) I am just wondering if it is necessary to use |
You are already using pandas, BeautifulSoup and Matplotlib, and docopt is an overall better solution than argparse for the full control of the --help output (argparse can do it of course, but, you will have to implement an argparse “formatter class", which is a real pain), also maintainability is generally better in the docopt case, Octparse is better for bigger projects, Argparse is just a pain thats why heroku created Octparse, but that's not the case here. |
Pandas and Matplotlib are usually already available for anaconda users. But, that's a good point regarding BeautifulSoup. I am going to merge it. Thank you again for the contribution! |
@MahmoudElsayad , I was trying your code, and I got only 10 results, instead of 200. Can you try in your machine as well to check if this is a bug? Here's what I did:
The .CSV file has only 10 lines. |
@MahmoudElsayad I will be reverting the pull request if I don't hear back from you in one week. Thank you for your understanding. |
Things i added to the python code:
1- Created a command-line interface using "Docopt"
2- Working for python 3.0x
3- Retrieving publications, and abstract too
4- Added 500ms delay for the blocking of google issue