-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAS dataset label #213
Merged
Merged
SAS dataset label #213
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3e62c48
make xpt v8 SAS-readable
reikoch 0c104fb
Merge branch 'dev' into xpt_v8
reikoch 842bf28
fix reading long variable names from xpt
reikoch 04fbfd7
Merge branch 'dev' of https://github.com/WizardMac/ReadStat into xpt_v8
reikoch 7fd50a4
Merge remote-tracking branch 'upstream/dev' into xpt_v8
reikoch 64a3501
correct "file_label" to "table_name"
reikoch 2d25432
Merge remote-tracking branch 'upstream/dev' into sas_metadata
reikoch bd79a61
reads and prints SAS dataset label
reikoch 5e7bd81
fix lengths of name and label for testing sas7bdat
reikoch 93cf318
nearly correct dataset labels
reikoch 66a20ba
dataset label offset needs short integer
reikoch 01d67da
finally right dataset label
reikoch b849f68
check text blob length for dataset label retrieval
reikoch 6065ea3
better protect pointers reading dataset label
reikoch 83b548d
fix writing test sas7bdats
reikoch 80d1843
write dataset labels into sas7bdat files
reikoch 828f481
avoid writing labels into SAS7BCAT files
reikoch 6dd6633
Merge remote-tracking branch 'upstream/dev' into sas_metadata
reikoch 2c83606
protect against bad pointer for first text blob
reikoch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think additional pointer validation is necessary here. We need to ensure:
memcmp
does not overruntext_blob_lengths[0]
off
is not larger thanctx->col_info[0].name_ref.offset
ctx->file_label
is not overrun during thememcpy
Additionally:
file_label
likely needs to be recoded. So I suggest usingreadstat_convert
here instead of thememcpy
. That will automatically solve the third issue. Something likeThen check the return value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be addressed with the last commit