Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hideHSB, not hideHSV #14

Closed
wmhartl opened this issue Jun 23, 2021 · 2 comments
Closed

hideHSB, not hideHSV #14

wmhartl opened this issue Jun 23, 2021 · 2 comments
Assignees
@Wondermarin
Labels
p: high s: fixed semver: major t: bug

Comments

@wmhartl
Copy link

wmhartl commented Jun 23, 2021 •
edited
Loading

My Environment

Dependency Version
Node.JS version vX.Y.Z
react-color-palette version vX.Y.Z

Expected Behavior:

according to the documentation:
hideHSV | bool | false | Hide HSV input.

example given:

Actual Behavior:

The hideHSV prop does not work; hideHSB does work:

Additional Context:

react-color-palette/src/components/ColorPicker.component.tsx line 14

Great library, thank you!
@Wondermarin
Copy link
Owner

Thank you for your feedback ❤️, I will fix it in the next update.

Wondermarin added a commit that referenced this issue Jun 26, 2021
@Wondermarin
fix!: hideHSB -> hideHSV (#14)
b6d8e8b
@Wondermarin
Copy link
Owner

Should be fixed in 6.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wondermarin Wondermarin

Labels
p: high s: fixed semver: major t: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wmhartl @Wondermarin