Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update archive-lesson-plan.php #1829

Closed
wants to merge 2 commits into from
Closed

Update archive-lesson-plan.php #1829

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e426830
Update archive-lesson-plan.php
cynthianorman Aug 28, 2023
49c9824
Update archive-lesson-plan.php
cynthianorman Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions wp-content/themes/pub/wporg-learn-2020/archive-lesson-plan.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,12 @@

<?php else : ?>
<section>
<div class="row align-middle between section-heading section-heading--with-space">
Copy link
Contributor

@adamwoodnz adamwoodnz Aug 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could change this layout to use a col class to limit the width of the title, something like:

		<div class="row gutters between section-heading section-heading--with-space">
			<?php the_archive_title( '<h1 class="section-heading_title h2 col-8">', '</h1>' ); ?>
			<?php get_template_part( 'template-parts/component', 'archive-search' ); ?>
		</div>

This is the approach taken with the section intro pattern:

Screenshot 2023-08-30 at 2 37 54 PM

Because this is a shared pattern there is more complexity to the change though unfortunately. This style rule is being applied to override the align-middle class, and is affecting the layout when changed to the above, when the class should actually just be removed:

@media only screen and (min-width: 768px) {
    .section-heading.row {
        align-items:baseline;
    }
}

In my tests that seems to be safe. I think we should try to remove this class from the template headings throughout the site, and then remove this style rule too.

<?php the_archive_title( '<h1 class="section-heading_title h2">', '</h1>' ); ?>
<div class="row align-right">
<?php get_template_part( 'template-parts/component', 'archive-search' ); ?>
Copy link
Contributor

@adamwoodnz adamwoodnz Aug 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the search before the title changes the mobile view, currently search is second:

</div>
<div class="row align-left">
<?php the_archive_title( '<h1 class="section-heading_title h2">', '</h1>' ); ?>
</div>

<hr>

Expand Down