Skip to content

Commit

Permalink
Skip failing navigation editor tests (#39746)
Browse files Browse the repository at this point in the history
  • Loading branch information
@talldan
talldan authored Mar 25, 2022
1 parent 9a195fc commit 0c0768f
Showing 1 changed file with 126 additions and 121 deletions.
247 changes: 126 additions & 121 deletions packages/e2e-tests/specs/experiments/navigation-editor.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -701,147 +701,152 @@ describe.skip( 'Navigation editor', () => {
expect( lastItemAttributes.isTopLevelLink ).toBeTruthy();
} );
} );
} );

describe( 'Delete menu button', () => {
useExperimentalFeatures( [ '#gutenberg-navigation' ] );
describe( 'Delete menu button', () => {
useExperimentalFeatures( [ '#gutenberg-navigation' ] );

beforeAll( async () => {
await deleteAllMenus();
await deleteAllLinkedResources();
} );

afterEach( async () => {
await deleteAllMenus();
await deleteAllLinkedResources();
} );
beforeAll( async () => {
await deleteAllMenus();
await deleteAllLinkedResources();
} );

afterEach( async () => {
await setBrowserViewport( 'large' );
} );
it.each( [ 'large', 'small' ] )(
`should retain menu when confirmation is canceled and the viewport is %s`,
async ( viewport ) => {
const menuName = 'Menu delete test';
await createMenu( { name: menuName }, menuItemsFixture );
await visitNavigationEditor();
await setBrowserViewport( viewport );
// Wait for the header to show the menu name.
await page.waitForXPath(
`//*[@role="region"][@aria-label="Navigation top bar"]//h2[contains(text(), "${ menuName }")]`
);
afterEach( async () => {
await deleteAllMenus();
await deleteAllLinkedResources();
} );

if ( viewport === 'small' ) {
const openSettingsSidebar = await page.waitForXPath(
'//button[@aria-label="Settings"][@aria-expanded="false"]'
afterEach( async () => {
await setBrowserViewport( 'large' );
} );
it.each( [ 'large', 'small' ] )(
`should retain menu when confirmation is canceled and the viewport is %s`,
async ( viewport ) => {
const menuName = 'Menu delete test';
await createMenu( { name: menuName }, menuItemsFixture );
await visitNavigationEditor();
await setBrowserViewport( viewport );
// Wait for the header to show the menu name.
await page.waitForXPath(
`//*[@role="region"][@aria-label="Navigation top bar"]//h2[contains(text(), "${ menuName }")]`
);
await openSettingsSidebar.click();
}

const deleteMenuButton = await page.waitForXPath(
'//*[@role="region"][@aria-label="Navigation settings"]//button[text()="Delete menu"]'
);
await deleteMenuButton.click();
if ( viewport === 'small' ) {
const openSettingsSidebar = await page.waitForXPath(
'//button[@aria-label="Settings"][@aria-expanded="false"]'
);
await openSettingsSidebar.click();
}

const cancelButton = await page.waitForXPath(
'//*[@role="dialog"]//button[text()="Cancel"]'
);
await cancelButton.click();
const deleteMenuButton = await page.waitForXPath(
'//*[@role="region"][@aria-label="Navigation settings"]//button[text()="Delete menu"]'
);
await deleteMenuButton.click();

const menuActionsDropdown = await page.waitForXPath(
`//*[contains(@class,"edit-navigation-menu-actions")]//h2[text()="${ menuName }"]`
);
const currentSelectedMenu = await page.evaluate(
( el ) => el.textContent,
menuActionsDropdown
);
const cancelButton = await page.waitForXPath(
'//*[@role="dialog"]//button[text()="Cancel"]'
);
await cancelButton.click();

expect( currentSelectedMenu ).toBe( menuName );
}
);
it.each( [ 'large', 'small' ] )(
`should delete menu when confirmation is confirmed and there are no other menus and the viewport is %s`,
async ( viewport ) => {
const menuName = 'Menu delete test';
await createMenu( { name: menuName }, menuItemsFixture );
await visitNavigationEditor();
await setBrowserViewport( viewport );
// Wait for the header to show the menu name.
await page.waitForXPath(
`//*[@role="region"][@aria-label="Navigation top bar"]//h2[contains(text(), "${ menuName }")]`
);
if ( viewport === 'small' ) {
const openSettingsSidebar = await page.waitForXPath(
'//button[@aria-label="Settings"][@aria-expanded="false"]'
const menuActionsDropdown = await page.waitForXPath(
`//*[contains(@class,"edit-navigation-menu-actions")]//h2[text()="${ menuName }"]`
);
const currentSelectedMenu = await page.evaluate(
( el ) => el.textContent,
menuActionsDropdown
);
await openSettingsSidebar.click();

expect( currentSelectedMenu ).toBe( menuName );
}
);
it.each( [ 'large', 'small' ] )(
`should delete menu when confirmation is confirmed and there are no other menus and the viewport is %s`,
async ( viewport ) => {
const menuName = 'Menu delete test';
await createMenu( { name: menuName }, menuItemsFixture );
await visitNavigationEditor();
await setBrowserViewport( viewport );
// Wait for the header to show the menu name.
await page.waitForXPath(
`//*[@role="region"][@aria-label="Navigation top bar"]//h2[contains(text(), "${ menuName }")]`
);
if ( viewport === 'small' ) {
const openSettingsSidebar = await page.waitForXPath(
'//button[@aria-label="Settings"][@aria-expanded="false"]'
);
await openSettingsSidebar.click();
}

const deleteMenuButton = await page.waitForXPath(
'//*[@role="region"][@aria-label="Navigation settings"]//button[text()="Delete menu"]'
);
await deleteMenuButton.click();
const deleteMenuButton = await page.waitForXPath(
'//*[@role="region"][@aria-label="Navigation settings"]//button[text()="Delete menu"]'
);
await deleteMenuButton.click();

const confirmButton = await page.waitForXPath(
'//*[@role="dialog"]//button[text()="OK"]'
);
await confirmButton.click();
const confirmButton = await page.waitForXPath(
'//*[@role="dialog"]//button[text()="OK"]'
);
await confirmButton.click();

await page.waitForXPath(
`//*[@role="button"][@aria-label="Dismiss this notice"]//*[text()='"${ menuName }" menu has been deleted']`
);
await page.waitForXPath(
`//*[@role="button"][@aria-label="Dismiss this notice"]//*[text()='"${ menuName }" menu has been deleted']`
);

// If the "Create your first menu" prompt appears, we know there are no remaining menus,
// so our test menu must have been deleted successfully.
const createFirstMenuPrompt = await page.waitForXPath(
'//h3[.="Create your first menu"]',
{
visible: true,
}
);
const noMenusRemaining = createFirstMenuPrompt ? true : false;
expect( noMenusRemaining ).toBe( true );
}
);
// If the "Create your first menu" prompt appears, we know there are no remaining menus,
// so our test menu must have been deleted successfully.
const createFirstMenuPrompt = await page.waitForXPath(
'//h3[.="Create your first menu"]',
{
visible: true,
}
);
const noMenusRemaining = createFirstMenuPrompt ? true : false;
expect( noMenusRemaining ).toBe( true );
}
);

it.each( [ 'large', 'small' ] )(
`should delete menu when confirmation is confirmed and there are other existing menus and the viewport is %s`,
async () => {
const menuName = 'Menu delete test';
await createMenu( { name: menuName }, menuItemsFixture );
await createMenu( { name: `${ menuName } 2` }, menuItemsFixture );
await visitNavigationEditor();
// Wait for the header to show the menu name
await page.waitForXPath(
`//*[@role="region"][@aria-label="Navigation top bar"]//h2[contains(text(), "${ menuName }")]`
);
it.each( [ 'large', 'small' ] )(
`should delete menu when confirmation is confirmed and there are other existing menus and the viewport is %s`,
async () => {
const menuName = 'Menu delete test';
await createMenu( { name: menuName }, menuItemsFixture );
await createMenu(
{ name: `${ menuName } 2` },
menuItemsFixture
);
await visitNavigationEditor();
// Wait for the header to show the menu name
await page.waitForXPath(
`//*[@role="region"][@aria-label="Navigation top bar"]//h2[contains(text(), "${ menuName }")]`
);

// Confirm both test menus are present
openMenuActionsDropdown();
const firstTestMenuItem = await getMenuItem( menuName );
const secondTestMenuItem = await getMenuItem( `${ menuName } 2` );
// Confirm both test menus are present
openMenuActionsDropdown();
const firstTestMenuItem = await getMenuItem( menuName );
const secondTestMenuItem = await getMenuItem(
`${ menuName } 2`
);

expect( firstTestMenuItem ).not.toBeNull();
expect( secondTestMenuItem ).not.toBeNull();
expect( firstTestMenuItem ).not.toBeNull();
expect( secondTestMenuItem ).not.toBeNull();

// Delete the first test menu
const deleteMenuButton = await page.waitForXPath(
'//*[@role="region"][@aria-label="Navigation settings"]//button[text()="Delete menu"]'
);
await deleteMenuButton.click();
// Delete the first test menu
const deleteMenuButton = await page.waitForXPath(
'//*[@role="region"][@aria-label="Navigation settings"]//button[text()="Delete menu"]'
);
await deleteMenuButton.click();

const confirmButton = await page.waitForXPath(
'//*[@role="dialog"]//button[text()="OK"]'
);
await confirmButton.click();
const confirmButton = await page.waitForXPath(
'//*[@role="dialog"]//button[text()="OK"]'
);
await confirmButton.click();

await page.waitForXPath(
`//*[@role="button"][@aria-label="Dismiss this notice"]//*[text()='"${ menuName }" menu has been deleted']`
);
await page.waitForXPath(
`//*[@role="button"][@aria-label="Dismiss this notice"]//*[text()='"${ menuName }" menu has been deleted']`
);

openMenuActionsDropdown();
const deletedTestMenuItem = await getMenuItem( menuName );
expect( deletedTestMenuItem ).toBeNull();
}
);
openMenuActionsDropdown();
const deletedTestMenuItem = await getMenuItem( menuName );
expect( deletedTestMenuItem ).toBeNull();
}
);
} );
} );

0 comments on commit 0c0768f

Please sign in to comment.