fixes from review

WordPress · Oct 12, 2020 · 0c1daa3 · 0c1daa3
1 parent 7c0eff0
commit 0c1daa3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 24 deletions.
diff --git a/packages/block-library/src/image/edit.js b/packages/block-library/src/image/edit.js
@@ -80,7 +80,7 @@ export function ImageEdit( {
 	insertBlocksAfter,
 	noticeOperations,
 	onReplace,
-	context,
+	context: { allowAlign = true, allowResize = true, isList = false },
 } ) {
 	const {
 		url = '',
@@ -91,7 +91,6 @@ export function ImageEdit( {
 		width,
 		height,
 		sizeSlug,
-		isListItem,
 	} = attributes;
 
 	const altRef = useRef();
@@ -110,12 +109,6 @@ export function ImageEdit( {
 		return getSettings().mediaUpload;
 	} );
 
-	const allowResize =
-		context.allowResize !== undefined ? context.allowResize : true;
-
-	const allowAlign =
-		context.allowBlockAlign !== undefined ? context.allowBlockAlign : true;
-
 	function onUploadError( message ) {
 		noticeOperations.removeAllNotices();
 		noticeOperations.createErrorNotice( message );
@@ -271,10 +264,10 @@ export function ImageEdit( {
 	}, [ isTemp ] );
 
 	useEffect( () => {
-		if ( context?.isList ) {
-			setAttributes( { isListItem: context.isList } );
+		if ( isList ) {
+			setAttributes( { isListItem: isList } );
 		}
-	}, [ context ] );
+	}, [ isList ] );
 
 	const isExternal = isExternalImage( id, url );
 	const controls = (
@@ -339,7 +332,7 @@ export function ImageEdit( {
 		/>
 	);
 
-	if ( isListItem ) {
+	if ( isList ) {
 		return (
 			<>
 				{ controls }
@@ -351,17 +344,17 @@ export function ImageEdit( {
 				</li>
 			</>
 		);
-	} else {
-		return (
-			<>
-				{ controls }
-				<figure { ...blockProps }>
-					{ image }
-					{ mediaPlaceholder }
-				</figure>
-			</>
-		);
 	}
+
+	return (
+		<>
+			{ controls }
+			<figure { ...blockProps }>
+				{ image }
+				{ mediaPlaceholder }
+			</figure>
+		</>
+	);
 }
 
 export default withNotices( ImageEdit );
diff --git a/packages/block-library/src/image/save.js b/packages/block-library/src/image/save.js
@@ -66,7 +66,7 @@ export default function save( { attributes } ) {
 		</>
 	);
 
-	if ( true === isListItem ) {
+	if ( isListItem ) {
 		return (
 			<li { ...useBlockProps.save() }>
 				<figure className={ classes }>{ figure }</figure>
@@ -83,7 +83,7 @@ export default function save( { attributes } ) {
 	}
 
 	return (
-		<figure className={ classes } { ...useBlockProps.save() }>
+		<figure { ...useBlockProps.save( { className: classes } ) }>
 			{ figure }
 		</figure>
 	);