Skip to content

Commit

Permalink
Element: Add and upgrade @types/{react,react-dom} dependencies (#25086)
Browse files Browse the repository at this point in the history
* Add @types/react and @types/react-dom dependency to element
  Fixes #23130
* Upgrade the type packages
* Add changelog
  • Loading branch information
sirreal authored Sep 7, 2020
1 parent 124eee7 commit 36cf82b
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 15 deletions.
24 changes: 16 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@
"@types/npm-package-arg": "6.1.0",
"@types/prettier": "1.19.0",
"@types/qs": "6.9.1",
"@types/react-dom": "16.9.5",
"@types/requestidlecallback": "0.3.1",
"@types/semver": "7.2.0",
"@types/sprintf-js": "1.1.2",
Expand Down
5 changes: 5 additions & 0 deletions packages/element/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## Unreleased

### Bug fix

- Declare @types/react and @types/react-dom dependencies which could cause type errors when using
this package with TypeScript ([#25086](https://github.com/WordPress/gutenberg/pull/25086))

## 2.14.0 (2020-05-14)

### New Feature
Expand Down
9 changes: 3 additions & 6 deletions packages/element/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,7 @@
"description": "Element React module for WordPress.",
"author": "The WordPress Contributors",
"license": "GPL-2.0-or-later",
"keywords": [
"wordpress",
"gutenberg",
"element",
"react"
],
"keywords": [ "wordpress", "gutenberg", "element", "react" ],
"homepage": "https://github.com/WordPress/gutenberg/tree/master/packages/element/README.md",
"repository": {
"type": "git",
Expand All @@ -26,6 +21,8 @@
"sideEffects": false,
"dependencies": {
"@babel/runtime": "^7.9.2",
"@types/react": "^16.9.0",
"@types/react-dom": "^16.9.0",
"@wordpress/escape-html": "file:../escape-html",
"lodash": "^4.17.19",
"react": "^16.13.1",
Expand Down

0 comments on commit 36cf82b

Please sign in to comment.