Fix broken license check script (#61868)

Co-authored-by: swissspidy <[email protected]>
Co-authored-by: gziolo <[email protected]>

package.json

@@ -303,7 +303,7 @@
 		"lint:pkg-json": "wp-scripts lint-pkg-json . 'packages/*/package.json'",
 		"native": "npm run --prefix packages/react-native-editor",
 		"other:changelog": "node ./bin/plugin/cli.js changelog",
-		"other:check-licenses": "concurrently \"wp-scripts check-licenses --prod --gpl2 --ignore=@react-native-community/cli,@react-native-community/cli-platform-ios\" \"wp-scripts check-licenses --dev\"",
+		"other:check-licenses": "concurrently \"wp-scripts check-licenses --prod --gpl2 --ignore=@react-native-community/cli,@react-native-community/cli-platform-ios,@ampproject/remapping,human-signals,fb-watchman,bser,walker,chrome-launcher,lighthouse-logger,chromium-edge-launcher\" \"wp-scripts check-licenses --dev --ignore=jackspeak,path-scurry,package-json-from-dist\"",
 		"preother:check-local-changes": "npm run docs:build",
 		"other:check-local-changes": "node ./bin/check-local-changes.js",
 		"other:cherry-pick": "node ./bin/cherry-pick.mjs",

packages/scripts/scripts/check-licenses.js

@@ -179,8 +179,8 @@ const child = spawn.sync(
 		'--json',
 		'--long',
 		'--all',
-		...( prod ? [ '--prod' ] : [] ),
-		...( dev ? [ '--dev' ] : [] ),
+		...( prod ? [ '--omit=dev' ] : [] ),
+		...( dev ? [ '--include=dev' ] : [] ),
 	],
 	/*
 	 * Set the max buffer to ~157MB, since the output size for
@@ -198,10 +198,14 @@ function traverseDepTree( deps ) {
 		const dep = deps[ key ];
 
 		if ( ignored.includes( dep.name ) ) {
-			return;
+			continue;
+		}
+
+		if ( Object.keys( dep ).length === 0 ) {
+			continue;
 		}
 
-		if ( ! dep.hasOwnProperty( 'path' ) ) {
+		if ( ! dep.hasOwnProperty( 'path' ) && ! dep.missing ) {
 			if ( dep.hasOwnProperty( 'peerMissing' ) ) {
 				process.stdout.write(
 					`${ WARNING } Unable to locate path for missing peer dep ${ dep.name }@${ dep.version }. `
@@ -213,17 +217,15 @@ function traverseDepTree( deps ) {
 				);
 			}
 		} else if ( dep.missing ) {
-			process.stdout.write(
-				`${ WARNING } missing dep ${ dep.name }@${ dep.version }. `
-			);
+			for ( const problem of dep.problems ) {
+				process.stdout.write( `${ WARNING } ${ problem }.\n` );
+			}
 		} else {
 			checkDepLicense( dep.path );
 		}
 
 		if ( dep.hasOwnProperty( 'dependencies' ) ) {
 			traverseDepTree( dep.dependencies );
-		} else {
-			return;
 		}
 	}
 }
@@ -272,6 +274,8 @@ function detectTypeFromLicenseText( licenseText ) {
 	);
 }
 
+const reportedPackages = new Set();
+
 function checkDepLicense( path ) {
 	if ( ! path ) {
 		return;
@@ -333,7 +337,7 @@ function checkDepLicense( path ) {
 	}
 
 	let detectedLicenseTypes = [ detectedLicenseType ];
-	if ( detectedLicenseType.includes( ' AND ' ) ) {
+	if ( detectedLicenseType && detectedLicenseType.includes( ' AND ' ) ) {
 		detectedLicenseTypes = detectedLicenseType
 			.replace( /^\(*/g, '' )
 			.replace( /\)*$/, '' )
@@ -345,6 +349,13 @@ function checkDepLicense( path ) {
 		return;
 	}
 
+	// Do not report same package twice.
+	if ( reportedPackages.has( packageInfo.name ) ) {
+		return;
+	}
+
+	reportedPackages.add( packageInfo.name );
+
 	process.exitCode = 1;
 	process.stdout.write(
 		`${ ERROR } Module ${ packageInfo.name } has an incompatible license '${ licenseType }'.\n`