checks if caption is empty in media lib and keeps the one written in …

…block
WordPress · Jan 15, 2020 · 6b49f7c · 6b49f7c
1 parent b448074
commit 6b49f7c
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/packages/block-library/src/image/edit.js b/packages/block-library/src/image/edit.js
@@ -175,15 +175,13 @@ export class ImageEdit extends Component {
 
 		let mediaAttributes = pickRelevantMediaFiles( media );
 
-		// If the current image is temporary but an alt or caption text was meanwhile written by the user,
-		// make sure the text is not overwritten.
-		if ( isTemporaryImage( id, url ) ) {
-			if ( alt ) {
-				mediaAttributes = omit( mediaAttributes, [ 'alt' ] );
-			}
-			if ( caption ) {
-				mediaAttributes = omit( mediaAttributes, [ 'caption' ] );
-			}
+		// If an alt or caption text was meanwhile written by the user,
+		// make sure the text is not overwritten by empty captions
+		if ( alt || ! get( mediaAttributes, [ 'alt' ] ) ) {
+			mediaAttributes = omit( mediaAttributes, [ 'alt' ] );
+		}
+		if ( caption || ! get( mediaAttributes, [ 'caption' ] ) ) {
+			mediaAttributes = omit( mediaAttributes, [ 'caption' ] );
 		}
 
 		let additionalAttributes;