Attempt to avoid DOM selector, check failures again

WordPress · Aug 14, 2024 · 8579290 · 8579290
1 parent 4c2ec17
commit 8579290
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/packages/block-editor/src/components/rich-text/index.js b/packages/block-editor/src/components/rich-text/index.js
@@ -363,6 +363,8 @@ export function RichTextWrapper(
 			return;
 		}
 
+		// Writing flow might be editable, so we should make sure focus goes to
+		// the root editable element.
 		while ( element.parentElement?.isContentEditable ) {
 			element = element.parentElement;
 		}

diff --git a/packages/block-editor/src/components/writing-flow/use-select-all.js b/packages/block-editor/src/components/writing-flow/use-select-all.js
@@ -28,13 +28,7 @@ export default function useSelectAll() {
 			const selectedClientIds = getSelectedBlockClientIds();
 
 			// Abort if there is selection, but it is not within a block.
-			if (
-				selectionRoot &&
-				! selectionRoot.closest(
-					`[data-block="${ selectedClientIds[ 0 ] }"]`
-				) &&
-				selectedClientIds.length < 2
-			) {
+			if ( selectionRoot && ! selectedClientIds.length ) {
 				return;
 			}