Improve submenu indicator styling

WordPress · Apr 16, 2020 · a85eb79 · a85eb79
1 parent 997521b
commit a85eb79
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/packages/block-library/src/navigation-link/edit.js b/packages/block-library/src/navigation-link/edit.js
@@ -279,12 +279,12 @@ function NavigationLinkEdit( {
 							/>
 						</Popover>
 					) }
+					{ showSubmenuIcon && (
+						<span className="wp-block-navigation-link__submenu-icon">
+							<ItemSubmenuIcon />
+						</span>
+					) }
 				</div>
-				{ showSubmenuIcon && (
-					<span className="wp-block-navigation-link__submenu-icon">
-						<ItemSubmenuIcon />
-					</span>
-				) }
 				<InnerBlocks
 					allowedBlocks={ [ 'core/navigation-link' ] }
 					renderAppender={

diff --git a/packages/block-library/src/navigation/index.php b/packages/block-library/src/navigation/index.php
@@ -255,9 +255,6 @@ function block_core_navigation_build_html( $attributes, $block, $colors, $font_s
 
 		$html .= '</span>';
 
-		$html .= '</a>';
-		// End anchor tag content.
-
 		// Append submenu icon to top-level item.
 		// it shows the icon as default, when 'showSubmenuIcon' is not set,
 		// or when it's set and also not False.
@@ -271,6 +268,9 @@ function block_core_navigation_build_html( $attributes, $block, $colors, $font_s
 			$html .= '<span class="wp-block-navigation-link__submenu-icon">' . block_core_navigation_render_submenu_icon() . '</span>';
 		}
 
+		$html .= '</a>';
+		// End anchor tag content.
+
 		if ( $has_submenu ) {
 			$html .= block_core_navigation_build_html( $attributes, $block, $colors, $font_sizes );
 		}

diff --git a/packages/block-library/src/navigation/style.scss b/packages/block-library/src/navigation/style.scss
@@ -85,7 +85,7 @@
 }
 
 .wp-block-navigation-link__submenu-icon {
-	padding: $grid-unit-10 * 0.75 $grid-unit-10 * 2;
+	padding-left: 1ch;
 
 	svg {
 		fill: currentColor;