Button: Try improving padding for icon + text buttons. (#46764)

* Button: Try improving padding for icon + text buttons. * Update changelog.
WordPress · Jan 13, 2023 · fae9da1 · fae9da1
1 parent f46202a
commit fae9da1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md
@@ -5,6 +5,7 @@
 ### Enhancements
 
 -   `Dropdown`: deprecate `position`  prop, use `popoverProps` instead ([46865](https://github.com/WordPress/gutenberg/pull/46865)).
+-   `Button`: improve padding for buttons with icon and text. ([46764](https://github.com/WordPress/gutenberg/pull/46764)).
 
 ### Internal
 

diff --git a/packages/components/src/button/style.scss b/packages/components/src/button/style.scss
@@ -282,14 +282,15 @@
 
 		&.has-text {
 			justify-content: start;
+			padding-right: 12px;
 		}
 
 		&.has-text svg {
-			margin-right: 8px;
+			margin-right: $grid-unit-10;
 		}
 
 		&.has-text .dashicon {
-			margin-right: 10px;
+			margin-right: $grid-unit-10 + 2px;
 		}
 	}