Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography: Add word break option #11956

Open
MYIG opened this issue Nov 16, 2018 · 12 comments
Open

Typography: Add word break option #11956

MYIG opened this issue Nov 16, 2018 · 12 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Internationalization (i18n) Issues or PRs related to internationalization efforts Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended
Milestone

Comments

@MYIG
Copy link

MYIG commented Nov 16, 2018

I suggest about readability few days ago and I think it fixed. Thank you so much. But... It is not better in real. it is like Hide ones head in the sand...

cap 2018-11-16 14-14-18-483
Readability in title becomes better!

cap 2018-11-16 14-14-12-709
But it is still bad in real.

cap 2018-11-16 14-10-30-806
it looks bad in editor too.

cap 2018-11-16 14-11-17-893
It looks bad too.

cap 2018-11-16 14-11-00-684
it looks bad too in archive too.

That green circles are all one word. But they break. even title break too... it doesn't break words in title only in editor. words in content is broken too... It is not because of gutenberg?

@designsimply designsimply added Internationalization (i18n) Issues or PRs related to internationalization efforts Needs Testing Needs further testing to be confirmed. labels Nov 16, 2018
@designsimply
Copy link
Member

To confirm, the line breaks are working properly for the title field in the editor but the line breaks are not working properly for paragraphs in the editor or when the published posts are viewed directly on the web?

Would it be possible for you to include sample text you used above so that I can use the same text in my own testing? I want to compare what you have typed in the screenshots to my own test.

May I please also know what theme you are using?

@designsimply designsimply added the [Status] Needs More Info Follow-up required in order to be actionable. label Nov 21, 2018
@MYIG
Copy link
Author

MYIG commented Nov 22, 2018

both. in editor and on the web. the line breaks works well only title in editor.

I updated gutenberg 4.5.1 but it don't change.

제가 프로 음악가가 되지는 않겠습니다만 예전부터 작곡을 해보고 싶었습니다. 한때는 꿈이었지만... 말 그대로 어렸을적 일이라서... 여튼 그러다보니 아이패드 에어 2를 구입했을 때부터 아이패드로 음악을 만드는 것에 대해 생각해봤습니다. 아이패드가 앱들이 성능도 솔직히 가격 생각하면 엄청나게 좋은 편이고 UI도 좋으면서도 개성도 풍부하고 다 좋은데 일일이 터치해서 음악을 만드는 것은 매우 불편합니다. 특히 미디를 할 때 말이죠. FL Studio를 가끔 쓰는데 컴퓨터로 음악 만들 때 마우스로도 조작하기 꽤나 불편하지만 그래도 이 친구는 키보드 단축키정도는 있습니다. 물론 컴퓨터로 할 때나 아이패드로 할 때나 마우스, 키보드, 혹은 터치로 하기보다는(다만 개인적으로 서피스에 있는 터치로 PC 버전 DAW를 할수 있다면 꽤나 편하게 하실 수 있지 않을까 합니다.) 미디 컨트롤러(= 마스터 키보드)를 사용하는 것이 더 좋을 것임은 자명합니다. 저는 Ckey 37Key라는 친구를 구입했습니다.

it is just Korean sample^^. line breaks don't work here too.

I use a tool called 'oxygen' and it said it is not theme. but I think it is not because of these tools. because I find other korean has same problem too.

@MYIG
Copy link
Author

MYIG commented May 8, 2019

hmm... korean in wordpress is becoming better and better. but I want it is most important in readability... please fix it.

@taggon
Copy link

taggon commented Apr 10, 2020

For those who tackle this, I add some information here:

  • I think this user wants all words to be preserved, not broken. (단어가 분리되지 않았으면 좋겠다고 보고하신 거 맞나요?) @MYIG Am I correct?
  • Line wraps in CJK work differently from latin based charset. CJK words can break at line ends even with overflow-wrap: break-word or word-break: normal. Only word-break: keep-all preserves CJK words.
  • As I understand, Chinese and Japanese text don't have white spaces between words but Korean text does. (Correct me if I'm wrong)
  • So the fix may need to set word-break: keep-all for .block-editor-block-list__block only when the locale is Korean.

cc @designsimply and @youknowriad


@MYIG Gutenberg renders the editor only. The broken words in the web page headings are supposed to be generated by the theme you're using.
(In Korean) 구텐버그는 에디터만 그립니다. 웹 페이지 제목에서 단어가 분리되는 건 사용하고 계신 테마에서 담당하는 부분일 것 같습니다.

@StevenDufresne
Copy link
Contributor

I am in agreement with @taggon on this.

  • The theme should be responsible for wrapping the text. Gutenberg shouldn't play a role in that.
  • We could add word-break: keep-all directly into the style editor. I'm not certain it should be restricted to korean though. Could it not just be added for all languages?

@MYIG
Copy link
Author

MYIG commented Apr 13, 2020

@taggon I don't know about chinese and japanese, but I feel Korean have those problem in whole web. Most korean website have same problem, not only wordpress... So I think gutenberg can't do it maybe... I just had hope but I feel sad...

I don't know about CJK and you talked about overflow-wrap: break-word or word-break: normal. Only word-break: keep-all preserves CJK words. How can I know about it more? I am not web designer...

@MYIG
Copy link
Author

MYIG commented Apr 13, 2020

@StevenDufresne I don't know about word-break: keep-all, so I don't know it will fix Korean problem or not.

@StevenDufresne
Copy link
Contributor

@StevenDufresne I don't know about word-break: keep-all, so I don't know it will fix Korean problem or not.

Sorry, I was not asking you specifically, I was asking everyone. I feel like we can add it as default since Gutenberg isn't a wysiwyg editor and it shouldn't have a negative impact on other languages.

For clarification,word-break: keep-all tells the browser to keep the words together and place the word on the next line if its too long.

@MYIG
Copy link
Author

MYIG commented Apr 13, 2020

@StevenDufresne Korean user is just 0.2% of wordpress world. But you will care whole wordpress users. Thank you so much about it!!

@taggon
Copy link

taggon commented Apr 13, 2020

@taggon I don't know about chinese and japanese, but I feel Korean have those problem in whole web. Most korean website have same problem, not only wordpress... So I think gutenberg can't do it maybe... I just had hope but I feel sad...

@MYIG 위에 달았던 코멘트 대부분은 나중에 이 문제를 다룰 개발자를 위해 남겨둔 정보입니다. 한국어로 썼던 부분만 확인하시면 됩니다.
(in English) Most of the information I left was for the engineers or designers who will handle this issue. Please don't mind that.

@MYIG
Copy link
Author

MYIG commented Apr 13, 2020

@taggon okay thank you^^

@talldan talldan added [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels Apr 16, 2020
@mtias mtias added the Needs Dev Ready for, and needs developer efforts label Jul 13, 2021
@talldan talldan added [Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Jul 23, 2024
@talldan talldan changed the title Readability is not better in real... Typography: Add word break option Jul 23, 2024
@talldan
Copy link
Contributor

talldan commented Jul 23, 2024

I've renamed this issue so it's a bit easier to find and added some more relevant labels.

I imagine this could be a setting in the global styles typography panel, though perhaps it could equally be a setting related to internationalization? Feels more like a typography thing to me.

Not sure if it'd also be needed for individual blocks too (perhaps for mixed language sites?), starting off with a global option could be an easy way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Internationalization (i18n) Issues or PRs related to internationalization efforts Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

7 participants