Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "we" from embed preview error message #13643

Closed
ocean90 opened this issue Feb 1, 2019 · 0 comments · Fixed by #13644
Closed

Remove "we" from embed preview error message #13643

ocean90 opened this issue Feb 1, 2019 · 0 comments · Fixed by #13644
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.

Comments

@ocean90
Copy link
Member

ocean90 commented Feb 1, 2019

Original report: https://core.trac.wordpress.org/ticket/46168

Avoid using subject "we" in the strings as below:

gutenberg/packages/block-library/src/embed/embed-preview.js

Line 58 in b8b7bff

<p className="components-placeholder__error">{ __( 'Sorry, we cannot preview this embedded content in the editor.' ) }</p>

Who are the "we"?

It would be better as:
Sorry, this embedded content cannot be previewed in the editor.

Similar message used in core:
https://github.com/WordPress/wordpress-develop/blob/2fe6670aff8dd9181678f18bf3048f099d0221a1/src/wp-admin/includes/ajax-actions.php#L3454
@ocean90 ocean90 added [Type] Enhancement A suggestion for improvement. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block library /packages/block-library labels Feb 1, 2019
@Rahmon Rahmon mentioned this issue Feb 2, 2019
Merged
5 tasks
kidunot89 added a commit to kidunot89/gutenberg that referenced this issue Feb 4, 2019
@kidunot89
WordPress#13643-fix removed
d439242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Block library /packages/block-library [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove "we" from messages Rahmon/gutenberg
1 participant
@ocean90