Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery: add support for optional captions #1443

Closed
mtias opened this issue Jun 26, 2017 · 5 comments
Closed

Gallery: add support for optional captions #1443

mtias opened this issue Jun 26, 2017 · 5 comments
Assignees
@mtias @jorgefilipecosta
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Priority] High Used to indicate top priority items that need quick attention

Comments

@mtias
Copy link
Member

mtias commented Jun 26, 2017

Individual images should have optional captions.
@mtias mtias added [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media labels Jun 26, 2017
@mtias mtias added this to the Beta 0.5.0 milestone Jul 4, 2017
@jasmussen jasmussen mentioned this issue Jul 5, 2017
Closed
@janw-me
Copy link
Contributor

janw-me commented Jul 5, 2017

A note, if you edit a gallery with the pencil you get the option in the normal gallery edit. It's just unused.

@mtias mtias mentioned this issue Jul 10, 2017
Closed
@mtias mtias modified the milestones: Beta 0.6.0, Beta 0.5.0 Jul 14, 2017
@mtias mtias modified the milestones: Beta 0.7.0, Beta 0.6.0 Jul 24, 2017
@mtias mtias mentioned this issue Aug 3, 2017
Closed
@karmatosed
Copy link
Member

This was discovered during @helen's trip into Gutenberg:

I can't edit captions on an inserted gallery? And adding captions to a new gallery doesn't actually show anything? Weird.

Here you can see a video of what I recreated (assuming it's the same thing)

2017-08-03 14 35 53

@mtias
Copy link
Member Author

mtias commented Aug 3, 2017 •
edited
Loading

This is how inline captions could work:

image

@karmatosed karmatosed added the [Priority] High Used to indicate top priority items that need quick attention label Aug 3, 2017
@mtias mtias removed this from the Beta 0.7.0 milestone Aug 4, 2017
@Axinet
Copy link

Axinet commented Oct 11, 2017

It would be great if it could be possible to add a caption to the whole gallery under it (the same as for a singular image - there could be all images related to one thing) or as this ticket suggests for every image in the gallery (in my opinion default/demo style should match with single image styles).

@jorgefilipecosta jorgefilipecosta self-assigned this Dec 28, 2017
@jorgefilipecosta jorgefilipecosta mentioned this issue Dec 28, 2017
Merged
@jorgefilipecosta
Copy link
Member

Captions were added to the gallery in PR #4199.

@Axinet Axinet mentioned this issue Feb 18, 2018
Closed
youknowriad pushed a commit that referenced this issue Jan 17, 2020
@koke
Merge pull request #1443 from wordpress-mobile/issue/1411-media-text-…
3e9536a 
…icon-dark

Fix icons for Media & Text in dark mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtias mtias

@jorgefilipecosta jorgefilipecosta

Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Priority] High Used to indicate top priority items that need quick attention
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@karmatosed @Axinet @mtias @janw-me @jorgefilipecosta