Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing an image in the Image block will remove the caption #19636

Closed
mrfoxtalbot opened this issue Jan 14, 2020 · 1 comment · Fixed by #19641
Closed

Replacing an image in the Image block will remove the caption #19636

mrfoxtalbot opened this issue Jan 14, 2020 · 1 comment · Fixed by #19641
Assignees
@draganescu
Labels
[Block] Image Affects the Image Block [Status] In Progress Tracking issues with work in progress

Comments

@mrfoxtalbot
Copy link

mrfoxtalbot commented Jan 14, 2020 •
edited
Loading

Steps to reproduce

  1. Create a new post
  2. Insert an image block
  3. Set an image
  4. Write a caption
  5. Replace the image

What I expected

I expected the caption to remain unaltered.

What happened instead

The caption was gone

Browser / OS version

WordPress 5.3.2 + Core version of Gutenberg (no plugin)
MacOS 10.13.6 (17G8030)
Chrome Version 79.0.3945.88

Screenshot / Video

Kapture 2020-01-14 at 16 25 58

Context / Source

#reallife #dogfooding
@draganescu draganescu self-assigned this Jan 14, 2020
@draganescu
Copy link
Contributor

Yes we had the same problem in the gallery block and the solution was to only replace if the caption in the gallery was different. If it is empty it looks like a bug.

@draganescu draganescu mentioned this issue Jan 14, 2020
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 14, 2020
@talldan talldan added the [Block] Image Affects the Image Block label Jan 21, 2020
@talldan talldan mentioned this issue Aug 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@draganescu draganescu

Labels
[Block] Image Affects the Image Block [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Checks if caption is empty in media lib and keeps the one written WordPress/gutenberg
3 participants
@draganescu @talldan @mrfoxtalbot