Checks if caption is empty in media lib and keeps the one written #19641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
draganescu
force-pushed
the
fix/caption-replaced-by-empty
branch
from
477494a to
6b49f7c
Compare
draganescu
force-pushed
the
fix/caption-replaced-by-empty
branch
from
6b49f7c to
4643556
Compare
|
Looks like some tests that need to be sorted @draganescu. |
|
@talldan tests pass! I mistakenly was treating alt the same way. Although I could do that in a separate PR, but will also need to alter a test in that case. Anyway this here is only about the caption. |
tellthemachines
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #19636
How has this been tested?
Tested locally.
Screenshots
Types of changes
Basically the behavior was there already but only for the temporary preview.